Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inplace mul! with StandardBasisVector #288

Open
bartvanerp opened this issue Mar 1, 2023 · 6 comments
Open

Add inplace mul! with StandardBasisVector #288

bartvanerp opened this issue Mar 1, 2023 · 6 comments
Labels
enhancement New feature or request performance

Comments

@bartvanerp
Copy link
Member

Currently we can only perform multiplications with the StandardBasisVector by creating a new vector/matrix. For performance reasons it might be beneficial to also support inplace operations here.
@bartvanerp bartvanerp added enhancement New feature or request performance labels Mar 1, 2023
@bartvanerp bartvanerp self-assigned this Mar 1, 2023
@bartvanerp
Copy link
Member Author

bartvanerp commented Mar 1, 2023 •
edited

Also check for *(Adjoint{ T, StandardBasisVector{T}}, AbstractMatrix) and extend get/set for Adjoint

@bartvanerp bartvanerp removed their assignment Mar 1, 2023
@bvdmitri
Copy link
Member

Related #344

@bvdmitri
Copy link
Member

bvdmitri commented Oct 5, 2023

Can we replace the entire thing with FillArrays and its OneElement?

@bartvanerp
Copy link
Member Author

Didn't know about this package, but I think yes

@bartvanerp
Copy link
Member Author

Just had a look at OneElement. I like their definition where they save the axes in the struct, where we constrain ourselves to the length. Nonetheless, they seem to lack some important functionality in terms of (triple) dot-products.

@bvdmitri
Copy link
Member

bvdmitri commented Oct 10, 2023 •
edited

Nonetheless, they seem to lack some important functionality in terms of (triple) dot-products.

Maybe we can make a PR for them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request performance
Projects
RxInfer
Status: 🤔 Ideas
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bvdmitri @bartvanerp