Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1-Dimensional NoiseModule implementations? #186

Open
mitchmindtree opened this issue Oct 15, 2017 · 3 comments
Open

1-Dimensional NoiseModule implementations? #186

mitchmindtree opened this issue Oct 15, 2017 · 3 comments

Comments

@mitchmindtree
Copy link

Hey folks, just came across noise-rs, looking really nice!

I often use 1D noise functions when working with audio or for any kind of pattern generation over time. I'd love to be able to use the abstractions provided by this crate for this purpose, however I noticed it looks like most noise types only support 2, 3 and 4 dimensions?

I was wondering if you'd be open to adding 1D implementations?

@Razaekel
Copy link
Owner

Hi @mitchmindtree and welcome!

In lieu of a dedicated 1D implementation, you could use the 2D implementations, but keep the second dimension constant, i.e. [x,0] for 2D and evaluate for varying x.

1D noise itself would not be out of the scope of this crate, and could be useful to have. It would need somebody to implement it, though.

@mitchmindtree
Copy link
Author

Thanks for the response! I'm happy to have a go at implementing this sometime in the coming weeks/months if noone beats me to it 👍

@cheako
Copy link

cheako commented Mar 28, 2019

Like wise with ND, there should be an API for 1D that just uses the 2D with a fixed y. If the use of this feature becomes popular ppl will work to make it more efficient and the benefit will trickle down... If the solution is to use 2D directly then if a 1D implementation is written it'll have far fewer users than it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants