Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stretching fails when dtt_lag='dynamic' #250

Open
asyates opened this issue Jan 7, 2022 · 0 comments
Open

Stretching fails when dtt_lag='dynamic' #250

asyates opened this issue Jan 7, 2022 · 0 comments
Assignees
Labels

Comments

@asyates
Copy link
Contributor

asyates commented Jan 7, 2022

Just noticed that stretching fails when trying to resolve interstation distance using dynamic windows instead of static. Occurs because we are passing arguments station1 and station2 as strings into get_interstation_distance() function i.e.

pair = jobs[0].pair
ref_name = pair.replace(':', '_')
station1, station2 = pair.split(":")

if dtt_lag == "static":
      minlag = dtt_minlag
else:
      minlag = get_interstation_distance(station1, station2, station1.coordinates) / dtt_v

so station1.coordinates fails with error:

AttributeError: 'str' object has no attribute 'coordinates'

Will aim to correct today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants