Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msnoise plot data_availability with component or allow wildcards #218

Open
shaharkadmiel opened this issue Apr 8, 2021 · 1 comment
Open

msnoise plot data_availability with component or allow wildcards #218

shaharkadmiel opened this issue Apr 8, 2021 · 1 comment

Comments

@shaharkadmiel
Copy link

msnoise plot data_availability currently needs a full 3 char channel string. We should allow to just pass a single char component (Z) or a channel string with wildcards (*PZ).
@ThomasLecocq
Copy link
Member

this was done actually, now the code checks for wildcards in the "?HZ" form https://github.com/ROBelgium/MSNoise/blob/master/msnoise/plots/data_availability.py#L42-L51

do you think we need to support both * and ? ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThomasLecocq @shaharkadmiel