Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align query result types with rdflib #230

Open
namedgraph opened this issue Sep 27, 2023 · 0 comments
Open

Align query result types with rdflib #230

namedgraph opened this issue Sep 27, 2023 · 0 comments

Comments

@namedgraph
Copy link

namedgraph commented Sep 27, 2023

This logic returns different representations based on the return format. I think this breaks the abstraction. The reasonable return type in this case would be rdflib's Result.

I think the method's return type should be the same as rdflib's Graph.query():

def convert(self) -> rdflib.query.Result:

so as to align querying in-memory and remote RDF sources. Or maybe the convert method is not required at all and query should return rdflib.query.Result.

@namedgraph namedgraph changed the title Why doesn't convert() return SPARQLResults for SELECT queries? Why doesn't convert() return SPARQLResult for SELECT queries? Sep 27, 2023
@namedgraph namedgraph changed the title Why doesn't convert() return SPARQLResult for SELECT queries? Why doesn't convert() return SPARQLResult for SELECT/ASK queries? Sep 27, 2023
@namedgraph namedgraph changed the title Why doesn't convert() return SPARQLResult for SELECT/ASK queries? Align query result types with rdflib Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant