Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plotting submodule - deprecation of QuakePlot class #33

Open
3 of 4 tasks
hemmelig opened this issue May 23, 2019 · 3 comments
Open
3 of 4 tasks

Plotting submodule - deprecation of QuakePlot class #33

hemmelig opened this issue May 23, 2019 · 3 comments
Assignees
@hemmelig
Labels
enhancement New feature or request

Comments

@hemmelig
Copy link
Member

hemmelig commented May 23, 2019 •
edited

I propose moving the SeisPlot class out into a submodule QMigrate.plot that contains a series of functions that can be called to plot:

  • Summary plot
  • Trace plots
  • Coalescence trace
  • Coalescence video

In theory this is an entirely internal change, so I see zero change for end users.

It has the added benefit of reducing complexity of the signal/scan.py file.
@hemmelig hemmelig added the enhancement New feature or request label May 23, 2019
@hemmelig hemmelig self-assigned this May 23, 2019
hemmelig added a commit that referenced this issue Jun 4, 2019
@hemmelig
refactor(signal/scan.py) move plot to submodule
1e74977 
Move plot class and associated functions to own submodule in order to
reduce the amount of code held in signal/scan.py. Generally more logical
to have them separated for clarity. Does not close issue #33 but is a
good start.

Addresses issue #33
@hemmelig
Copy link
Member Author

hemmelig commented Jun 4, 2019

For now I have just moved the SeisPlot class to a new submodule, plot. I still think breaking this down into separate scripts in the submodule for each type of plot will help clean up the code somewhat, but the priority was to reduce the amount of code in signal/scan.py

@hemmelig hemmelig mentioned this issue Jun 4, 2019
Merged
@hemmelig
Copy link
Member Author

Summary plots for phase picks have been revamped and the function that produces the base figure has been moved to the plot module.

@hemmelig
Copy link
Member Author

hemmelig commented May 5, 2020

Summary plots for triggered event summaries and located events summaries have been revamped and the plotting functions moved to independent submodules in the plot module.

The only remaining work to be done is the coalescence video.

@hemmelig hemmelig changed the title plot submodule Plotting submodule - deprecation of QuakePlot class May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hemmelig hemmelig

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hemmelig