Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional _check_condition_number for snapshots #462

Open
klapo opened this issue Sep 12, 2023 · 1 comment
Open

Optional _check_condition_number for snapshots #462

klapo opened this issue Sep 12, 2023 · 1 comment

Comments

@klapo
Copy link
Contributor

klapo commented Sep 12, 2023

Is your feature request related to a problem? Please describe.
When doing multiresolution scale separation it is common for data windows to have a poor condition number. snapshots.Snapshots gives a warning for each window sometimes numbering in the thousands.

Describe the solution you'd like
I would like to add an argument to disable the _check_condition_number step.

Describe alternatives you've considered
Since this poor condition number is to be expected for certain cases such as small decomposition windows, the warnings have to be disabled, which is a suboptimal solution.

Additional context
This would be implemented for the COSTS method in the roadmap. If a different solution is preferred that would have more general utility I would be happy to implement that instead, for instance logging the message at a different level.

@mtezzele
Copy link
Contributor

Maybe we can exploit the logging functionalities to address this case.
I would wait for other comments on this, because I am not sure on the best solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants