Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we remove idna hacks from NormalizeURLString? #30

Open
let4be opened this issue Mar 5, 2020 · 2 comments
Open

Can we remove idna hacks from NormalizeURLString? #30

let4be opened this issue Mar 5, 2020 · 2 comments

Comments

@let4be
Copy link

let4be commented Mar 5, 2020

Any idea if the fix was merged to idna package?

https://github.com/PuerkitoBio/purell/blob/master/purell.go#L166
Is this still relevant?

@mna
Copy link
Member

mna commented Mar 6, 2020

I have no idea, if anyone wants to check and submit a PR if that's now taken care of, happy to merge it.

@dolmen
Copy link

dolmen commented Nov 17, 2020

Here is the direct link to the golang.org/x/net/idna package history for the next one who will investigate this: https://github.com/golang/net/commits/master/idna

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants