Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

No mention of "active slots" setting in Global Concurrency Limits section of documentation #13361

Open
2 tasks done
tristanchambers-bids opened this issue May 15, 2024 · 4 comments
Labels
docs needs:details Blocked by a need for more info from user

Comments

@tristanchambers-bids
Copy link

tristanchambers-bids commented May 15, 2024

First check

  • I added a descriptive title to this issue.
  • I used GitHub search to find a similar request and didn't find it 馃槆

Describe the issue

The Add Concurrency Limit dialog box has a setting called "Active Slots". But this setting is not explained in the documentation, nor is there a tooltip to explain the effect of this setting. The docs list all of the other settings on this dialog box:

Name: The name of the concurrency limit. This name is also how you'll reference the concurrency limit in your code. Special characters, such as /, %, &, >, <, are not allowed.
Concurrency Limit: The maximum number of slots that can be occupied on this concurrency limit.
Slot Decay Per Second: Controls the rate at which slots are released when the concurrency limit is used as a rate limit. This value must be configured when using the rate_limit function.
Active: Whether or not the concurrency limit is in an active state.
Screen Shot 2024-05-15 at 6 35 40 AM

Describe the proposed change

Add a line to the list of settings explaining the effect of this setting.

Additional context

I'd like to get my concurrency limits set up, but I'm not confident that I'm doing it right without understanding this setting.

@tristanchambers-bids tristanchambers-bids added docs needs:triage Needs feedback from the Prefect product team labels May 15, 2024
@serinamarie serinamarie added status:accepted We may work on this; we will accept work from external contributors and removed needs:triage Needs feedback from the Prefect product team status:accepted We may work on this; we will accept work from external contributors labels May 28, 2024
@serinamarie
Copy link
Contributor

Hi, @tristanchambers-bids, we have a section in the documentation for this-- were you able to locate this guide?

@serinamarie serinamarie added the needs:details Blocked by a need for more info from user label May 28, 2024
@jeffrose-relay
Copy link

@serinamarie I am struggling with this too. This guide you linked does not mention the Active Slots field or what it means. I have even looked in the source code but there is nothing helpful there either.
image
image

@tristanchambers-bids
Copy link
Author

Hi @serinamarie yes those are the docs I was referring to in my issue description. I updated to clarify. This page has no mention of the words "Active Slots".

@tristanchambers-bids
Copy link
Author

For those who are scratching their head like me, I discovered today that "Active Slots" is not a parameter that you set. It is in fact a variable which keeps track of how many slots are currently claimed. The system increments and decrements the value when each task is added and completed (respectively). Why is this a user editable value you may ask? Well it turns out that when you cancel a job, the system does not decrement the active slots value for any tasks that were killed. So after you cancel a job you should check this value and set it to zero if there were any killed tasks that did not complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs needs:details Blocked by a need for more info from user
Projects
None yet
Development

No branches or pull requests

3 participants