Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab completion should not replace ~ or variables #5350

Open
lzybkr opened this issue Nov 6, 2017 · 4 comments · May be fixed by #21148
Open

Tab completion should not replace ~ or variables #5350

lzybkr opened this issue Nov 6, 2017 · 4 comments · May be fixed by #21148
Labels
In-PR Indicates that a PR is out for the issue Issue-Enhancement the issue is more of a feature request than a bug KeepOpen The bot will ignore these and not auto-close WG-Interactive-IntelliSense tab completion
Milestone
Future

Comments

@lzybkr
Copy link
Member

lzybkr commented Nov 6, 2017

Tab completion should not replace ~ or variables.

E.g.

cd ~\<TAB>
vim $env:APPDATA\<TAB>
& $env:SystemRoot\<TAB>

When editing a script, the replacement might actually make the script less portable, e.g. $env:SystemRoot isn't always on the c: drive.

On the command line, you normally end up with a longer command line, and possibly less meaningful. It can also be less useful when searching your history.

We could have an option that control this behavior, but I suspect it should be the default.
@lzybkr lzybkr added WG-Interactive-IntelliSense tab completion Issue-Enhancement the issue is more of a feature request than a bug labels Nov 6, 2017
@lzybkr lzybkr mentioned this issue Nov 6, 2017
Closed
@SteveL-MSFT SteveL-MSFT added this to the 6.1.0 milestone Nov 6, 2017
@iSazonov
Copy link
Collaborator

iSazonov commented Nov 7, 2017

Can we have a way (Alt-Shift) to replace ~ or variables still?

@lzybkr
Copy link
Member Author

lzybkr commented Nov 7, 2017

A key binding depends on the host - e.g. PSReadLine or PS Editor Services - not something the core engine needs to provide, except perhaps an api to do the replacement.

A new api probably isn't worth it, various editors also want to support older versions of PowerShell and this replacement isn't that hard to implement with existing apis.

@SteveL-MSFT SteveL-MSFT modified the milestones: 6.2.0-Consider, Future Jun 21, 2018
@MartinGC94 MartinGC94 mentioned this issue Jul 13, 2022
Merged
22 tasks
@danbradham
Copy link

This issue seems to have gone stale, thought I'd give it a bump.

I run into this on a daily basis and I sort of just live with it even though it irritates me and leads to extraneous key presses!

@masterflitzer
Copy link

yes this is so annoying, especially when working with both bash and pwsh on a regular basis (i notice it every single day)

@MartinGC94 MartinGC94 mentioned this issue Apr 11, 2023
Merged
22 tasks
@mklement0 mklement0 mentioned this issue Jul 27, 2023
Closed
5 tasks
@kilasuit kilasuit added the WG-NeedsReview Needs a review by the labeled Working Group label Jul 28, 2023
@domsleee domsleee mentioned this issue Sep 29, 2023
Open
@mklement0 mklement0 mentioned this issue Nov 24, 2023
Closed
5 tasks
@MartinGC94 MartinGC94 linked a pull request Jan 28, 2024 that will close this issue
Open
22 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR Indicates that a PR is out for the issue label Jan 28, 2024
@SteveL-MSFT SteveL-MSFT added KeepOpen The bot will ignore these and not auto-close and removed WG-NeedsReview Needs a review by the labeled Working Group labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In-PR Indicates that a PR is out for the issue Issue-Enhancement the issue is more of a feature request than a bug KeepOpen The bot will ignore these and not auto-close WG-Interactive-IntelliSense tab completion
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Stop replacing variables in path tab completion MartinGC94/PowerShell
6 participants
@lzybkr @danbradham @kilasuit @SteveL-MSFT @iSazonov @masterflitzer