-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop a way so that a calculated T_verwey in the MPMS_verwey_fit notebook can be added to the MagIC contribution #11
Comments
I like the idea of appending calculated values to a MagIC contribution. We do much the same thing in the IRM database. |
One thing that would be nice to do in addition to putting in the value would be to also append a comment that explains how the value was determined (and could include the temperature bounds + polynomial order). |
It would be ideal if that could be done in an automated way, rather than requesting the user to add this information. |
Indeed. We should be able to do that within the notebook. I am thinking that we can make a "dictionary" data object that provides this info. It is going to be more straightforward to do this for a user that is using the function within a code cell than the ipywidget UI. So I can look to build that out first. After that, we can see how it could be integrated into someone who is using the widget approach (or decide to walk the user through the code cell approach without implementing in the widgets). |
A note in terms of working on this is that there are tools available within the contribution_builder.py that makes a Contribution class: These notebooks introduce associated functionality (which I need to familiarize myself with): https://github.com/PmagPy/PmagPy/blob/master/data_files/notebooks/Intro%20to%20MagicDataFrames.ipynb We can work with this class instead of importing individual files using Pandas which should give a framework for updating newly calculated values. So the code:
can be replaced with:
|
Made a bunch of progress on this issue with ccb77ad |
As discussed in #14, need to write out to the specific row associated with the experiment for which the Verwey fit was made (i.e. ZFC vs FC). |
We are going to take the approach of simply appending a new row to the specimens table with the newly calculated values. |
Making good progress here. The
Now that the contribution object is being written to, I think it likely makes sense to put the code within a function and to then also take the next step of generating an updated MagIC file. |
It makes sense to have the calculations made in the MPMS_verwey_fit be appended to the MagIC contribution and for an updated contribution to then be made. The notebook can be extended to accomplish this task. Implementing an approach in this regard will be important for calculations in other notebooks such as Curie temperatures and hysteresis parameters.
The text was updated successfully, but these errors were encountered: