ipmag.vgpmag_magic erases 'normal' poles if there are reverse ones

[ltauxe]

What command was run:

ipmag.vgpmap_magic(dir_path=dir_path,size=50,flip=True,save_plots=True,lat_0=60,rsym='b^',rsize=50,fmt='png')

and

ipmag.vgpmap_magic(dir_path=dir_path,size=50,flip=False,save_plots=True,lat_0=60,rsym='b^',rsize=50,fmt='png')

What happened:

There are no 'normal' poles when flip is set to True. This used to work but something happened!

What I expected to happen:

I expect the red and blue symbols as advertized for when flip is set to True

Data file(s):
sites.txt

Screenshot(s):
plot with both normal and reverse data only shows only reverse poles:

without flip, you get only the normal poles (as expected).

The way it is supposed to work (and does on jupyterhub.earthref.org, weirdly, with the same version of PmagPy).

PmagPy version:
pmagpy-4.2.98

[Swanson-Hysell]

It looks like the code is first plotting the normal:

    if len(lats) > 0:
        # add the lats and lons of the poles
        pmagplotlib.plot_map(FIG['map'], lats, lons, Opts)

and then plotting the reversed:

    if len(rlats) > 0:
        Opts['sym'] = rsym
        Opts['symsize'] = rsize
        # add the lats and lons of the poles
        pmagplotlib.plot_map(FIG['map'], rlats, rlons, Opts)

What might be happening is that the land and ocean in the second pmagplotlib.plot_map() is covering up the first set of points.

[ltauxe]

yeah but the flag ‘pltgrid’ in Opts is turned off, so it isn’t supposed to do that. I tried a bunch of things and couldn’t get it to work…. lisa

…

On Apr 13, 2022, at 2:07 PM, Nick Swanson-Hysell ***@***.***> wrote: It looks like the code is first plotting the normal: if len(lats) > 0: # add the lats and lons of the poles pmagplotlib.plot_map(FIG['map'], lats, lons, Opts) and then plotting the reversed: if len(rlats) > 0: Opts['sym'] = rsym Opts['symsize'] = rsize # add the lats and lons of the poles pmagplotlib.plot_map(FIG['map'], rlats, rlons, Opts) What might be happening is that the land and ocean in the second pmagplotlib.plot_map() is covering up the first set of points. — Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PmagPy_PmagPy_issues_649-23issuecomment-2D1098488155&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=HLmFoB00cDyPMQ7s6Fl35Q&m=YdK6F0MjPiTwHkeOagnlXs_8odwLk_4TIhDaYRAT6oATfT9R-gwwfaQCeMD83Pe7&s=trk8Koexbsga_k8ypR-gfDTYYjmAHus-4x2saelRbb4&e=>, or unsubscribe <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AABKWDJBV6YJJPWHJACYIU3VE4ZQ7ANCNFSM5TL2D6EA&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=HLmFoB00cDyPMQ7s6Fl35Q&m=YdK6F0MjPiTwHkeOagnlXs_8odwLk_4TIhDaYRAT6oATfT9R-gwwfaQCeMD83Pe7&s=9fBa9bVAP8HAfAZjNb4lUKIvTG8VIvujmAVTJRBEu7Q&e=>. You are receiving this because you authored the thread.

[ltauxe]

and the really weird thing is that the exact same code works perfectly well on the jupyterhub site. maybe I should just move on…. lisa

…

On Apr 13, 2022, at 2:07 PM, Nick Swanson-Hysell ***@***.***> wrote: It looks like the code is first plotting the normal: if len(lats) > 0: # add the lats and lons of the poles pmagplotlib.plot_map(FIG['map'], lats, lons, Opts) and then plotting the reversed: if len(rlats) > 0: Opts['sym'] = rsym Opts['symsize'] = rsize # add the lats and lons of the poles pmagplotlib.plot_map(FIG['map'], rlats, rlons, Opts) What might be happening is that the land and ocean in the second pmagplotlib.plot_map() is covering up the first set of points. — Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PmagPy_PmagPy_issues_649-23issuecomment-2D1098488155&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=HLmFoB00cDyPMQ7s6Fl35Q&m=YdK6F0MjPiTwHkeOagnlXs_8odwLk_4TIhDaYRAT6oATfT9R-gwwfaQCeMD83Pe7&s=trk8Koexbsga_k8ypR-gfDTYYjmAHus-4x2saelRbb4&e=>, or unsubscribe <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AABKWDJBV6YJJPWHJACYIU3VE4ZQ7ANCNFSM5TL2D6EA&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=HLmFoB00cDyPMQ7s6Fl35Q&m=YdK6F0MjPiTwHkeOagnlXs_8odwLk_4TIhDaYRAT6oATfT9R-gwwfaQCeMD83Pe7&s=9fBa9bVAP8HAfAZjNb4lUKIvTG8VIvujmAVTJRBEu7Q&e=>. You are receiving this because you authored the thread.

[Swanson-Hysell]

An inelegant solution that works is where:

    if len(rlats) > 0:
        Opts['sym'] = rsym
        Opts['symsize'] = rsize
        # add the lats and lons of the poles
        pmagplotlib.plot_map(FIG['map'], rlats, rlons, Opts)

is replaced with:

    if len(rlats) > 0:
        Opts['sym'] = rsym
        Opts['symsize'] = rsize
        if len(lats) > 0:
            color, symbol = Opts['sym'][0], Opts['sym'][1]
            plt.gca().scatter(rlons, rlats, s=Opts['symsize'], c=color, marker=symbol,
                              transform=ccrs.PlateCarree(), edgecolors=Opts['edgecolor'])
        else:
            pmagplotlib.plot_map(FIG['map'], rlats, rlons, Opts)

[Swanson-Hysell]

That solution just plots with scatter on the already generated axis and gives:

[Swanson-Hysell]

yeah but the flag ‘pltgrid’ in Opts is turned off, so it isn’t supposed to do that. I tried a bunch of things and couldn’t get it to work…. lisa
…

I think it is the plotting of the oceans and land rather than the grid that is hiding the normal points when the reversed map is generated with pmagplotlib.plot_map().

It is likely preferable to be using the map that is already generated rather than making a whole new map (which is what the edited code above does). I can commit that if it looks ok to you.

[ltauxe]

yes please. that whole function needs re-writing I guess - but not today! lisa

…

On Apr 13, 2022, at 2:31 PM, Nick Swanson-Hysell ***@***.***> wrote: yeah but the flag ‘pltgrid’ in Opts is turned off, so it isn’t supposed to do that. I tried a bunch of things and couldn’t get it to work…. lisa … <x-msg://62/#> I think it is the plotting of the oceans and land rather than the grid that is hiding the normal points when the reversed map is generated with pmagplotlib.plot_map(). It is likely preferable to be using the map that is already generated rather than making a whole new map (which is what the edited code above does). I can commit that if it looks ok to you. — Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PmagPy_PmagPy_issues_649-23issuecomment-2D1098506958&d=DwMFaQ&c=-35OiAkTchMrZOngvJPOeA&r=HLmFoB00cDyPMQ7s6Fl35Q&m=fTRpZCKe4xM1Y2nYlddrDs5nMqjOBBUPvzI5AYL4bHzdIp3lVs6_hEUYS-OIDvHl&s=3EsInp0g452cM36F2XfqXwKZA7lm5K_YAFllqZzju64&e=>, or unsubscribe <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AABKWDKK5GKD67KLVICFKXTVE44J5ANCNFSM5TL2D6EA&d=DwMFaQ&c=-35OiAkTchMrZOngvJPOeA&r=HLmFoB00cDyPMQ7s6Fl35Q&m=fTRpZCKe4xM1Y2nYlddrDs5nMqjOBBUPvzI5AYL4bHzdIp3lVs6_hEUYS-OIDvHl&s=QlL3IUuaLvV3pbXGF1V5WPGtdn3LW9KQ3RIV2cKu78w&e=>. You are receiving this because you authored the thread.

[Swanson-Hysell]

Did commit e2a7b00 solve the issue? If so, we can go ahead and close.

[ltauxe]

no it didn’t. sorry.

…

On Apr 20, 2022, at 3:54 PM, Nick Swanson-Hysell ***@***.***> wrote: Did commit e2a7b00 <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PmagPy_PmagPy_commit_e2a7b00060a939d5b45224fd9eaad53dc4bb2d6f&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=HLmFoB00cDyPMQ7s6Fl35Q&m=DYdK0kzCw7aVzPJIzs5ee-WMpaKy5fJG885Hh6m5-FGfXAaBHOwfJtg46W_Frh3q&s=T_Ngxt8hB5hHoFGsFZ1iLOF24ASthf_IYu5d2bU0Ov0&e=> solve the issue? If so, we can go ahead and close. — Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PmagPy_PmagPy_issues_649-23issuecomment-2D1104531479&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=HLmFoB00cDyPMQ7s6Fl35Q&m=DYdK0kzCw7aVzPJIzs5ee-WMpaKy5fJG885Hh6m5-FGfXAaBHOwfJtg46W_Frh3q&s=MfHhMRvOk--1ZCn5bp1yFYY5ylODohnPldN4atXpiiQ&e=>, or unsubscribe <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AABKWDI2IXDOEWJBCDB2XS3VGCDL3ANCNFSM5TL2D6EA&d=DwMCaQ&c=-35OiAkTchMrZOngvJPOeA&r=HLmFoB00cDyPMQ7s6Fl35Q&m=DYdK0kzCw7aVzPJIzs5ee-WMpaKy5fJG885Hh6m5-FGfXAaBHOwfJtg46W_Frh3q&s=17p1-dOjg0MMiXmujvBdD_HWXbUSAiC-bxhrT6X4k8s&e=>. You are receiving this because you authored the thread.