CI codecov bug

[pheuer]

The following bug is consistently appearing in CI, most recently on #2636

@namurphy I know you were working on this - what's going on?

Run codecov/codecov-action@v4
==> macos OS detected
https://cli.codecov.io/latest/macos/codecov.SHA256SUM
==> Running version latest
==> Running version v0.5.0
==> Running git config --global --add safe.directory /Users/runner/work/PlasmaPy/PlasmaPy
/usr/local/bin/git config --global --add safe.directory /Users/runner/work/PlasmaPy/PlasmaPy
==> Running command '/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit'
/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit --git-service github -C 820c6125898674b4ba[15](https://github.com/PlasmaPy/PlasmaPy/actions/runs/8692894835/job/23838847746#step:7:16)f2b5e3d2a554e3689930 -Z
info - 2024-04-15 [16](https://github.com/PlasmaPy/PlasmaPy/actions/runs/8692894835/job/23838847746#step:7:17):54:40,854 -- ci service found: github-actions
gpg: directory '/Users/runner/.gnupg' created
gpg: /Users/runner/.gnupg/trustdb.gpg: trustdb created
gpg: key 806BB28AED779869: public key "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" imported
gpg: Total number processed: 1
gpg:               imported: 1
gpg: Signature made Wed Apr 10 [17](https://github.com/PlasmaPy/PlasmaPy/actions/runs/8692894835/job/23838847746#step:7:18):26:43 2024 UTC
gpg:                using RSA key 27034E7FDB850E0BBC2C62FF806BB28AED779869
gpg: Good signature from "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 2703 4E7F DB85 0E0B BC2C  62FF 806B B28A ED77 9869
==> Uploader SHASUM verified (86ca1c1acdbb0b72ab16b3f10a6f7612169df1ef02fc3888cb[18](https://github.com/PlasmaPy/PlasmaPy/actions/runs/8692894835/job/23838847746#step:7:19)07dbf44e3aef  codecov)
info - 2024-04-15 16:54:41,266 -- The PR is happening in a forked repo. Using tokenless upload.
info - 2024-04-15 16:54:41,616 -- Process Commit creating complete
error - [20](https://github.com/PlasmaPy/PlasmaPy/actions/runs/8692894835/job/23838847746#step:7:21)24-04-15 16:54:41,617 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 177 seconds."}
Error: Codecov: Failed to properly create commit: The process '/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

[namurphy]

Hm...it seems like uploading coverage from forks can only occur at a maximum rate. I suspect this may have been happening before, and we're only noticing it now because I set codecov to fail when uploading coverage fails.

I'm not quite sure how to address this, other than to let the Codecov action succeed in CI even if it can't be uploaded (i.e., to revert the setting that I changed). If we do that, then we should make sure that the corresponding weekly test that does coverage should fail when it is not able to upload stuff. It may be possible to set up Codecov tokens that work for forks too.

I might not be able to get to this this week, so in the meantime it may be best to think of this as an allowed failure. Thank you for raising this!

[namurphy]

We've also been getting this error, seemingly intermittently: Error: Codecov token not found. Please provide Codecov token with -t flag.

Run codecov/codecov-action@v4
  with:
    file: ./coverage.xml
    fail_ci_if_error: false
  env:
    GH_TOKEN: ***
    pythonLocation: /Users/runner/hostedtoolcache/Python/3.11.9/arm64
    PKG_CONFIG_PATH: /Users/runner/hostedtoolcache/Python/3.11.9/arm64/lib/pkgconfig
    Python_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.11.9/arm64
    Python2_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.11.9/arm64
    Python3_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.11.9/arm64
    CODECOV_TOKEN: 
==> macos OS detected
https://cli.codecov.io/latest/macos/codecov.SHA256SUM
==> Running version latest
==> Running version v0.5.2
==> Running git config --global --add safe.directory /Users/runner/work/PlasmaPy/PlasmaPy
/opt/homebrew/bin/git config --global --add safe.directory /Users/runner/work/PlasmaPy/PlasmaPy
==> Running command '/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit'
/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit --git-service github -C 55cd63bf025493cdd3db7df90928bd5cedfa8ae9
info - 2024-04-30 19:28:44,631 -- ci service found: github-actions
Error: Codecov token not found. Please provide Codecov token with -t flag.
Warning: Codecov: Failed to properly create commit: The process '/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
gpg: directory '/Users/runner/.gnupg' created
gpg: /Users/runner/.gnupg/trustdb.gpg: trustdb created
gpg: key 806BB28AED779869: public key "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" imported
gpg: Total number processed: 1
gpg:               imported: 1

gpg: Signature made Thu Apr 18 16:30:51 2024 UTC
gpg:                using RSA key 27034E7FDB850E0BBC2C62FF806BB28AED779869
gpg: Good signature from "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 2703 4E7F DB85 0E0B BC2C  62FF 806B B28A ED77 9869

==> Uploader SHASUM verified (90dc400a8fb20f91cacd2a694a515ecfe399adfe24294ae02613d513c1b18171  codecov)