Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend/node-red-dashboard: you can change the flowrate during an acquisition #317

Open
pkostyrka opened this issue Dec 21, 2023 · 2 comments
Labels
bug Something isn't working software
Milestone

Comments

@pkostyrka
Copy link

Describe the bug
During an acquisition, you can go in optic configuration and change the flowrate. It creates a bug in the software, and it should not be possible to do that.

To Reproduce
Steps to reproduce the behavior:

  1. Launch an acquistion
  2. Go to optic configuration
  3. Change the flowrate

Expected behavior
It should not be possible to change the flowrate when an acquisition is launched.

@pkostyrka pkostyrka added bug Something isn't working software labels Dec 21, 2023
@ethanjli ethanjli added this to the Backlog milestone Dec 21, 2023
@ethanjli
Copy link
Member

When you change the value of the flow rate input box on the optic configuration page during acquisition, what consequences do you observe? e.g. does the pump start running at the new flow rate?

@ethanjli ethanjli changed the title You can change the flowrate during an acquisition frontend/node-red-dashboard: you can change the flowrate during an acquisition Dec 22, 2023
@ethanjli
Copy link
Member

ethanjli commented Apr 13, 2024

@melissadjadoun the redesign of the MQTT API should probably make the API return an error to any API client which attempts to change the flowrate while an image-acquisition sequence is running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working software
Projects
Status: 📋 Plan needed
Development

No branches or pull requests

2 participants