Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The flowrate has an incorrect calibration #289

Open
pkostyrka opened this issue Nov 22, 2023 · 3 comments
Open

The flowrate has an incorrect calibration #289

pkostyrka opened this issue Nov 22, 2023 · 3 comments
Labels
bug Something isn't working software
Milestone

Comments

@pkostyrka
Copy link

Describe the bug
With a 2045 step/ml for the pump with a flowrate of 5 mL/min, when you pass 10 mL, the pump effectively pass 10 mL.
But, it takes around 3 minutes, when it should be 2 minutes. So the real flowrate is around 3.5 mL/min.
(I did this on ten units).

To Reproduce
Steps to reproduce the behavior:

  1. OPTIC CONFIGURATION
  2. Pass 10 mL with a flowrate of 5 mL/min. Measure the time. It should be 2 minutes if the real flowrate is 5 mL/min. But it is not the case.

Expected behavior
If you enter a flowrate, it should be the real flowrate.

@pkostyrka pkostyrka added bug Something isn't working software labels Nov 22, 2023
@ethanjli
Copy link
Member

ethanjli commented Nov 22, 2023

In general, the flowrate needs to be calibrated for each machine following the procedure described at https://www.protocols.io/view/planktoscope-protocol-for-plankton-imaging-bp2l6bq3zgqe/v2?step=4 . In other words, it is currently the responsibility of the user to adjust the hardware settings in order to make the flowrates be correct.

However, I'd like to have the software provide reasonable defaults for the calibration parameters. Those default parameters are specific to each version of the PlanktoScope hardware. Which version of the PlanktoScope hardware are you using? My pump stepper motor calibration of 2045 steps/mL was obtained on a PlanktoScope with v2.6.1 hardware.

@ethanjli ethanjli changed the title The flowrate is not the real flowrate The flowrate has an incorrect calibration Nov 23, 2023
@ethanjli
Copy link
Member

ethanjli commented Nov 28, 2023

Update: I just realized that I misread your description, so I misunderstood the problem you were reporting. If I understand correctly now, you actually do have a correct calibration for the pump_steps_per_ml setting, since the pump will pump exactly 10 mL of fluid when you tell it to pump 10 mL of fluid. Instead, it seems that there is some other setting which will need to be calibrated in order to calibrate the pump flowrate. In other words, calibrating the pump's volumes is not sufficient to calibrate the pump's flowrates.

@ethanjli ethanjli added this to the Backlog milestone Nov 28, 2023
@pkostyrka
Copy link
Author

Yes that's right !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working software
Projects
Status: 📋 Plan needed
Development

No branches or pull requests

2 participants