Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkcon: Use appropriate finish call for each async call #751

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pkcon: Use appropriate finish call for each async call #751

wants to merge 1 commit into from

Conversation

sidt4
Copy link
Contributor

@sidt4 sidt4 commented May 10, 2024

Fixes: #747

@ximion
Copy link
Collaborator

ximion commented May 12, 2024

Instead of adding that extra variable, could you define two dispatch functions pk_console_client_finished_cb and pk_console_task_finished_cb that extract the PkResults and forward it to a generic pk_console_process_results function?

That would do away with the extra variable and might be a bit cleaner...

@sidt4 sidt4 force-pushed the use_appopriate_generic_finish branch from d51546d to f4f2799 Compare May 14, 2024 20:53
@sidt4
Copy link
Contributor Author

sidt4 commented May 14, 2024

Fixed.

ximion
ximion requested changes May 21, 2024
View reviewed changes
client/pk-console.c Outdated Show resolved Hide resolved
client/pk-console.c Outdated Show resolved Hide resolved
client/pk-console.c Outdated Show resolved Hide resolved
@sidt4 sidt4 force-pushed the use_appopriate_generic_finish branch from f4f2799 to aadb68d Compare May 21, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ximion ximion ximion requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pk_task_generic_finish: assertion 'G_IS_SIMPLE_ASYNC_RESULT (res)' failed
2 participants
@sidt4 @ximion