-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calculate_xray_build_id broken when date earlier than 31.01.1999 #1611
Comments
Is it possible to robustly get the exact current date? Ignoring |
Ignoring |
The simplest workaround I see it to replace |
Should be fairly easy to fix. What about just returning |
Describe the bug
xray-16/cmake/utils.cmake
Lines 52 to 53 in 92c550c
https://cmake.org/cmake/help/v3.28/command/string.html#timestamp notes:
SOURCE_DATE_EPOCH
is often set to a value that results in a date of 01.01.1970 or 01.01.1980. This seemingly breaks the calculation here:xray-16/cmake/utils.cmake
Lines 61 to 62 in 92c550c
Which finally produces an invalid project version, erroring out the configure call:
To Reproduce
Steps to reproduce the behavior:
export SOURCE_DATE_EPOCH=315532800
, meaning 01.01.1980Expected behavior
CMake configuring doesn't break.
Screenshots, videos
n/a
BugTrap error report
n/a
Desktop (please complete the following information):
Additional context
I guess this was a problem since that function was introduced, but it only ever affected the banner on launch.
The text was updated successfully, but these errors were encountered: