Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code to support host-only API base URLs #176

Open
jimallman opened this issue May 5, 2016 · 2 comments
Open

Update code to support host-only API base URLs #176

jimallman opened this issue May 5, 2016 · 2 comments
Assignees
@jimallman
Labels
bug

Comments

@jimallman
Copy link
Member

jimallman commented May 5, 2016 •
edited

In the current indexing code, we build URLs assuming old-school base URLs. So far, this has not been a problem, but it will fail if we update the production/api system-config file to use host-only base URLs, as we currently do in the development/devapi file.

EDIT: Fixed system-config file links (thanks @kcranston!)
@jimallman jimallman self-assigned this May 5, 2016
@jimallman jimallman added the bug label May 5, 2016
@jimallman
Copy link
Member Author

On a related note, just a reminder that some dependencies on v1 APIs remain, for example this URL for deferred pushes to GitHub, which points to

https://devapi.opentreeoflife.org/phylesystem/push/v1

@jimallman
Copy link
Member Author

Also restored this (internal) v1 API for fetching duplicate study IDs.

@jimallman jimallman mentioned this issue May 9, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimallman jimallman

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimallman