Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up ^ot:curatedType #8

Open
kcranston opened this issue May 2, 2016 · 1 comment
Open

clean up ^ot:curatedType #8

kcranston opened this issue May 2, 2016 · 1 comment

Comments

@kcranston
Copy link
Member

The nexsons include a property called ^ot:curatedType. In the UI, this is called 'Inference method'. It is currently a pulldown that provides various inference options (Bayesian inference, Maximum Likelihood, Maximum Parsimony, etc) but it used to be a free text field. As you might expect, the field is full of all sorts of free-form descriptions for trees, including software used, Figure numbers, genes used, consensus methods, etc.

If you want to see the list of values, there is a peyotl script for that:

$ python ot_phylesystem_list_property_values.py --set --tree ^ot:curatedType

It would be nice to clean up this field, moving non-standard values into another field (@description, perhaps?) and possibly renaming the field to ^ot:inferenceMethod to match both the UI and the search term for the find_trees API call. Related to the discussion on this otttreeindex issue.

@jimallman
Copy link
Member

FYI, there's a stale branch (and a PR that was closed long ago) that addresses these issues, particularly in this commit: OpenTreeOfLife/opentree@ad7d5f7

GitHub shows the PR as already merged, but the relevant bits are not in current master. (perhaps we merged, then backed out these changes?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants