Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections metadata confusion #1344

Open
snacktavish opened this issue May 16, 2024 · 1 comment
Open

Collections metadata confusion #1344

snacktavish opened this issue May 16, 2024 · 1 comment

Comments

@snacktavish
Copy link
Member

snacktavish commented May 16, 2024

https://github.com/OpenTreeOfLife/collections-1/blob/master/collections-by-owner/snacktavish/aves.json#L178

For some reason several (but not all) studies in this collection have metadata about "ot:studyPublicationReferenc" as well as "ot:studyPublicationReference"

They are often both the same, but not always. I am confuse!

"ot:studyPublicationReferenc": "Hruska, J. P., Holmes, J., Oliveros, C., Shakya, S., Lavretsky, P., McCracken, K. G., Sheldon, F. H., & Moyle, R. G. (2023). Ultraconserved elements resolve the phylogeny and corroborate patterns of molecular rate variation in herons (Aves: Ardeidae). Ornithology. https://doi.org/10.1093/ornithology/ukad005\n",
"ot:studyPublicationReference": "No matching publication found for this DOI!",`
``

I put the issue here, but I don't_ actually know where it comes form... could be otindex.
jimallman referenced this issue May 21, 2024
NB - This will also require a sweep of the collections in phylesystem,
to correct the stored property name and clear up any collections that
have both `ot:studyPublicationReferenc` and `ot:studyPublicationReference`
properties.
@jimallman
Copy link
Member

This is my fault! I had a typo in the Javascript for building and storing collections. The fix is referenced above, and has already been merged into branch staging.

NB - Existing collections in phylesystem might have redundant properties, so we'll need a batch operation to clean up and disambiguate some collections, esp. if there are different values for ot:studyPublicationReferenc and ot:studyPublicationReference. I've added the phylesystem batch operation label to this issue so it doesn't get lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants