Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crash]: Crash after kicking spectator #12655

Closed
WenSimEHRP opened this issue May 11, 2024 · 1 comment · Fixed by #12660
Closed

[Crash]: Crash after kicking spectator #12655

WenSimEHRP opened this issue May 11, 2024 · 1 comment · Fixed by #12660

Comments

@WenSimEHRP
Copy link

Version of OpenTTD

20240510-master-ga5c2543efc, Windows 11

Steps to reproduce

  1. Start a new server
  2. let another client join the server and then join or found a new company
  3. kick the player
    image
  4. notice "spectators" is kickable and kick spectators
    image
  5. Crash!

Upload crash files

crash.zip

@rubidium42
Copy link
Contributor

rubidium42 commented May 11, 2024

Also reproducible in 14.1.

What seems to be the problem is twofold.

  1. The client lists caches the buttons that are available and what they can do.
  2. Due to deferred deletion of the client, the window invalidation is still done when the client object exists. So at row 3 there's still a client when the button lists are rebuilt, but once it has gone away that becomes the row with the spectator 'company' line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants