-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it clear that summary is mandatory for Wikibase upload #6306
Comments
? It's not mandatory on the side of the website that is being uploaded to (at least not on Wikibases, Wikidata, Wikimedia Commons) so the upload should not fail on the OpenRefine side if the user does not fill in anything. |
@thadguidry yes it would be good to have a unified way to mark such fields as required (I also can't remember on top of my mind any field in the UI where we currently signal the fact that it is required visually). It would be useful for instance for the column name field in "add column based on this column". I can share why I made this field mandatory when first developing this feature (happy to change it). When uploading edits to a Wikibase, OpenRefine tries to minimize the number of edits it makes on each entity. For instance, if you are adding two statements on the same Wikidata item, they will generally be added in a single edit. That saves time and computing resources on the Wikibase instance. As a consequence, the edit summary that is automatically generated by Wikibase for this edit will be something like "Updated Item: ". When reviewing the history of a Wikidata item, those sorts of summaries are very uninformative, so I thought it's good to encourage users to supply a more descriptive summary of their own. |
Hello, i would like to be assigned this issue. |
I would go for marking the field as required. I am not sure if we use the If I remember correctly, when trying to validate the form without a summary, we currently only focus the field but not make it clearer that it's required. In some forms there is an additional explanation that shows up in such a case, such as a "This field is required." in red. Maybe we could also consider that. |
I just remembered that HTML actually has a |
When I was close to finishing my Wikibase edit and needed to add a summary in the upload menu, it wasn't clear to me that the summary was mandatory for the upload to work.
Let's add a visual cue - for example, an asterisk - to indicate the field is required.
The text was updated successfully, but these errors were encountered: