Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change crossingMode to a strong enum #22014

Closed
Gymnasiast opened this issue May 10, 2024 · 0 comments · Fixed by #22020
Closed

Change crossingMode to a strong enum #22014

Gymnasiast opened this issue May 10, 2024 · 0 comments · Fixed by #22020
Labels
good-first-issue Low hanging fruits good for people new to open source or OpenRCT2. refactor A task that will improve code readability, without changing outcome.

Comments

@Gymnasiast
Copy link
Member

Create an enum class for crossing mode and rename the current CREATE_CROSSING_MODE_* constants according to the new rules (i.e. createCrossingMode*). Change the functions that currently take one as an uint8_t to use this strong enum.
@Gymnasiast Gymnasiast added refactor A task that will improve code readability, without changing outcome. good-first-issue Low hanging fruits good for people new to open source or OpenRCT2. labels May 10, 2024
Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this issue May 11, 2024
@Gymnasiast
Close OpenRCT2#22014: Change crossingMode to a strong enum
8f2bc7f
@Gymnasiast Gymnasiast linked a pull request May 11, 2024 that will close this issue
Close #22014: Change crossingMode to a strong enum #22020
Merged
duncanspumpkin pushed a commit that referenced this issue May 12, 2024
@Gymnasiast
Close #22014: Change crossingMode to a strong enum (#22020)
5407ba2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Low hanging fruits good for people new to open source or OpenRCT2. refactor A task that will improve code readability, without changing outcome.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close #22014: Change crossingMode to a strong enum Gymnasiast/OpenRCT2
1 participant
@Gymnasiast