Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin rdkit on mypy #844

Closed
IAlibay opened this issue Apr 28, 2024 · 3 comments · Fixed by #733
Closed

Unpin rdkit on mypy #844

IAlibay opened this issue Apr 28, 2024 · 3 comments · Fixed by #733

Comments

@IAlibay
Copy link
Contributor

IAlibay commented Apr 28, 2024

Opening up this PR so we remember to do this.

@mikemhenry I believe you put the pin in, do you know if there's an issue upstream to work out why this duplicate self is happening?

@mikemhenry
Copy link
Contributor

Yes the error was that there was a syntax error with the rdkit typing stubs and that pinned version fixed it, I can try and fix that on #733

@mikemhenry
Copy link
Contributor

This is the mypy error: /home/runner/micromamba/envs/openfe_env/lib/python3.11/site-packages/rdkit-stubs/Chem/rdMolDescriptors.pyi:247: error: Duplicate argument "self" in function definition seen with rdkit 2024.03.2 py311h1d78c4b_0 conda-forge

I will see if 2023.09.5 works but with python relaxed (it was pined to 3.9 which was causing the issues with the env solving).

@mikemhenry
Copy link
Contributor

Also see rdkit/rdkit#7401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants