Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run deploy github workflows one at a time #2030

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Run deploy github workflows one at a time #2030

wants to merge 2 commits into from

Conversation

taylordowns2000
Copy link
Member

@taylordowns2000 taylordowns2000 commented Apr 25, 2024 •
edited by midigofrank

Description

this is just a concept:

  1. needs testing
  2. maybe (probably) also needs the workflow to pull/merge previously made changes... see @mtuchi 's latest error when he reruns the workflow.
  • we want workflow a to run
  • then we want workflow b to run
  • they are both triggered by the same commit, but they do different things because we have multiple unrelated openfn projects in the same repo.
  • how do we stop the conflicts?

Related Issue

Fixes #2044

@taylordowns2000
Copy link
Member Author

you can test this by modifying the workflow in place @mtuchi . the "fix" is just for automatically generated workflows from lightning.

@midigofrank midigofrank changed the title concept for fix Run deploy github workflows one at a time Jun 3, 2024
@midigofrank
Copy link
Collaborator

@mtuchi I have tested that this actually runs the workflows one at a time. When you get some time, do modify the github workflows in the project with this option and see the how it works

@codecov Codecov
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.61%. Comparing base (5e916ab) to head (628bdef).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2030   +/-   ##
=======================================
  Coverage   89.61%   89.61%           
=======================================
  Files         270      270           
  Lines        8957     8957           
=======================================
  Hits         8027     8027           
  Misses        930      930

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtuchi mtuchi Awaiting requested review from mtuchi

At least 2 approving reviews are required to merge this pull request.

Assignees

@midigofrank midigofrank

Labels
None yet
Projects
v2
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflict occurs during github sync when 2 workflows are triggered by the same commit
2 participants
@taylordowns2000 @midigofrank