New SharedDomain extension #2025
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyeshe
force-pushed
the
new-project-extension
branch
4 times, most recently
from
75e41e6
to
9792113
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2025 +/- ##
==========================================
+ Coverage 90.04% 90.07% +0.02%
==========================================
Files 249 251 +2
Lines 8219 8228 +9
==========================================
+ Hits 7401 7411 +10
+ Misses 818 817 -1 ☔ View full report in Codecov by Sentry. |
jyeshe
force-pushed
the
new-project-extension
branch
2 times, most recently
from
5863b64
to
aea0282
Compare
jyeshe
force-pushed
the
new-project-extension
branch
3 times, most recently
from
32cf4f8
to
6bf5cfc
Compare
jyeshe
force-pushed
the
new-project-extension
branch
from
6bf5cfc
to
ee42fc0
Compare
jyeshe
force-pushed
the
new-project-extension
branch
from
ee42fc0
to
117fd3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation Steps
i) Register a new user
ii) Create a new user via super user UI
ii) Create a new project via super user UI
Notes for the reviewer
Allows adding other entities while registering a new user or creating a new project.
It's called whenever a new user is registered and a new project is created.
Related issue
Fixes #2029
Review checklist
:owner,:admin,:editor,:viewer) have been implemented and tested