Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker: better error messages on credentials #692

Open
josephjclark opened this issue May 14, 2024 · 1 comment
Open

Worker: better error messages on credentials #692

josephjclark opened this issue May 14, 2024 · 1 comment

Comments

@josephjclark
Copy link
Collaborator

When the worker fails to load a credential, it'll just log a generic error message.

We need to ensure that if Lightning returns an error on the credential, that the error makes it back to the run logs.

As part of this issue, I also want to make sure we've got good unit and integration tests around this area (at a quick look it seems not too bad)

See OpenFn/lightning#1842

@josephjclark
Copy link
Collaborator Author

One fun thing here is that this happens before the run technically starts. It's part of the lost logs without a step id. I think lightning will just ignore it.

Anyway, so long as we throw a better error message out of the credential loader, we'll show the message as the exit reason and everything will be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Icebox
Development

No branches or pull requests

1 participant