Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker: do something better when the JWT expires #688

Open
josephjclark opened this issue May 10, 2024 · 0 comments
Open

Worker: do something better when the JWT expires #688

josephjclark opened this issue May 10, 2024 · 0 comments

Comments

@josephjclark
Copy link
Collaborator

We've had some problems lately with the JWT on the run channel expiring , causing messages to fail.

It looks a bit like this:

image

The worker should do better in these cases, throwing a clear error and existing the channel and maybe the socket.

The question is WHERE we report. We can't tell lightning because, well, the JWT expired. Any attempts to send a message back will be rejected.

This comes into monitoring - we don't have a monitoring solution yet, other than lightning and GCP.

Perhaps a good approach is to shut the whole server down (probably gracefully) with a clear error like "expired JWT detected" and stop requesting traffic. That depends a bit whether it's one run that's expired or whether all JWTs are wrong.

We probably don't unit test for any of this very well at the moment. I think unit testing and clear logs to GCP are the first step. That also makes it easier for us to trace where to add more monitoring later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Icebox
Development

No branches or pull requests

1 participant