You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* #671: configured prettier
* Removed the pre-hook commit section and also minimized the Readme.md file
* also added test:lint or test:format script in package.json which can be run locally or in CI
* Delete ci.yaml
* Updated changes
* Update pnpm-lock.yaml
Resolved conflicts
* Update pnpm-lock.yaml
* Update package.json
* Update pnpm-lock.yaml
* Update pnpm-lock.yaml
* changed the versions for consistency
It's really important that prettier runs so that we have a consistent code style.
But new developers coming in to contribute to the repo may not have prettier configured.
My expectation is:
We may need to add documentation to the readme, but ideally this stuff should happen automatically.
I have my VSC setup to format on save, which uses prettier. But this won't work for other editing environments.
We should look at how prettier recommends this to be setup on their officlal pages and be guided by that.
I would prefer not to format pre-commit. The idea of changing code, invisibly, right before commit it to the repo, makes my blood run cold.
The text was updated successfully, but these errors were encountered: