Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink CircleCI workflow triggers #672

Open
josephjclark opened this issue Apr 19, 2024 · 0 comments
Open

Rethink CircleCI workflow triggers #672

josephjclark opened this issue Apr 19, 2024 · 0 comments

Comments

@josephjclark
Copy link
Collaborator

CircleCI is set up to run a suite of tests on branches.

At the moment it looks like it runs the build_and_test workflow on any non main branch.

One problem with this is that when contributors raise a PR from a form, and their fork is on main and targeting main, our CI won't run. This means we have to merge without automated tests - which is very very bad.

Another problem I think is that any branch which is pushed will have CI run on it. But this is likely to be a waste of computation on 80% of branches.

I think the setup we want is to run CircleCI on any open PR, regardless of what the branch is. Maybe even non-draft PRs, if we can do that.

What that really means is that CI tests only run on branches which are complete (or close to complete)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Icebox
Development

No branches or pull requests

1 participant