Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker isn't running NODE_ENV=production ? #651

Open
josephjclark opened this issue Apr 5, 2024 · 0 comments
Open

worker isn't running NODE_ENV=production ? #651

josephjclark opened this issue Apr 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@josephjclark
Copy link
Collaborator

The worker environment isn't running with NODE_ENV set to production.

This isn't neccessarily a problem, but it does mean that Lightning is printing deprecation notices on the old common.http helpers. It shouldn't really be doing that - the deprecation notice is designed only to come out in the CLI because the message is targeted at adaptor writers. Job writers can't do anything about it.

Probably the main worker server is running in prod mode, but the nested child process worker environment isn't inheriting it.

Maybe its even the sandbox - the sandbox, very deliberately, doesn't inherit the parent env. But maybe we should pipe NODE_ENV through.

@josephjclark josephjclark added the bug Something isn't working label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant