Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation errors and hints when parsing project configuration #4

Open
stuartc opened this issue Feb 8, 2021 · 1 comment
Open

Comments

@stuartc
Copy link
Member

stuartc commented Feb 8, 2021

We would like some helpful error messages when parsing/coercing project configuration.

  • Check that a CriteriaTrigger is formatted correctly
  • Ensure jobs link to existing triggers
  • Ensure there is at least something in the expression for a job
@stuartc stuartc self-assigned this Feb 8, 2021
@stuartc
Copy link
Member Author

stuartc commented Apr 7, 2021

ensure the adaptor field is set on a job.

In addition AdaptorService should get the adaptor names from the Config struct instead of reading the config directly to avoid future changes not being made in both places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant