Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display on required properties in sample configuration #471

Closed
2 tasks done
mtuchi opened this issue Apr 15, 2024 · 0 comments · Fixed by #492
Closed
2 tasks done

Display on required properties in sample configuration #471

mtuchi opened this issue Apr 15, 2024 · 0 comments · Fixed by #492
Assignees

Comments

@mtuchi
Copy link
Contributor

mtuchi commented Apr 15, 2024

Description

Currently the sample configuration section on docs. Displays all configuration-schema properties regardless if they are required or not. This causes lot's of confusion especially for new users who are using the adaptor for the first time.

The request In few words

  • Display only required properties in sample-configuration schema
  • Make sure all properties type accurately matches the configuration schema type. For Boolean property it should show a boolean value and not a string value. Eg:Postgresql adaptor . ssl: true not ssl: "true". Of
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant