Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should probably only document Operations #443

Open
josephjclark opened this issue Mar 19, 2024 · 2 comments
Open

We should probably only document Operations #443

josephjclark opened this issue Mar 19, 2024 · 2 comments

Comments

@josephjclark
Copy link
Contributor

I've just been doing some documentation work and I've got a whole bit about how "not all adaptor functions are operations".

And while that's technically true, there's only a small number of exceptions and I don't think any of them are designed for job writers.

Life would be a lot easier if we only publicly documented the actual Operations and hid everything else away.

@josephjclark
Copy link
Contributor Author

@taylordowns2000 I'd appreciate your thoughts on this one! Do we want to be exposing stuff like this from common?

image

And if so, shouldn't it just be an operation which writes to state.data?

I sort of see the value of utility functions which you can use inside fn blocks and callbacks - in fact I've started designing adaptors around this pattern (with a utils file which exports stuff as utils). There are loads of common patterns which would be useful for job writers (although they probably favour functional programmers which maybe isn't the right audience for us).

But they really complicate the story. Something Aleksa said in Nairobi is that they weren't sure whether something was an Operation and whether/how they could use the return.

Maybe we think a bit later about splitting up Operations and Utilities in the docs.

@josephjclark
Copy link
Contributor Author

Hmm - fields() is an example of a nice utility function which isn't an operation. Although if course it could be...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant