Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still issues with non-ascii characters in various places #1563

Open
coumbsek opened this issue Dec 7, 2022 · 1 comment
Open

Still issues with non-ascii characters in various places #1563

coumbsek opened this issue Dec 7, 2022 · 1 comment

Comments

@coumbsek
Copy link

coumbsek commented Dec 7, 2022

How did you install ODM? (Docker, installer, natively, ...)?

Windows natively

What is the problem?

If ODM is installed in a path where there are non-ascii characters (for instance accentuated ones) ODM can not run properly.
See here for more info.

What should be the expected behavior? If this is a feature request, please describe in detail the changes you think should be made to the code, citing files and lines where changes should be made, if possible.

Be able to use ODM no matter what characters are in the install path.

How can we reproduce this? What steps did you do to trigger the problem? If this is an issue with processing a dataset, YOU MUST include a copy of your dataset uploaded on Google Drive or Dropbox (otherwise we cannot reproduce this).

Install ODM in a folder with accent, for instance "C:\testé"

@coumbsek
Copy link
Author

coumbsek commented Dec 7, 2022

It seems that the corresponding package has been added along with the automatic sky-removal feature in commit b584459.

Since first issue literally comes from importing of the package not sure of what our options are...
According to the repo of the lib the first point is just a warning ?
The error we are seeing when running may not be related.

microsoft/onnxruntime#13499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants