Skip to content
This repository has been archived by the owner on Dec 20, 2021. It is now read-only.

Clean up Animation.Clone #873

Open
gravestench opened this issue Oct 28, 2020 · 0 comments
Open

Clean up Animation.Clone #873

gravestench opened this issue Oct 28, 2020 · 0 comments
Labels
Code Cleanup Doesn't materially affect the game Help Wanted Extra attention is needed Low Priority For issues that are nice to have, but not essential.
Projects
OpenDiablo 2 Game Engine

Comments

@gravestench
Copy link
Contributor

The Clone method of animations is sloppy and warrants a refactor.

Please see :

  • d2common/d2interface/animation.go
  • d2core/d2asset/animation.go
  • d2core/d2asset/dcc_animation.go
  • d2core/d2asset/dc6_animation.go

In particular, we need to get rid of the nasty type-casting in dc6_animation.go and dcc_animation.go
@gravestench gravestench added Help Wanted Extra attention is needed Code Cleanup Doesn't materially affect the game Low Priority For issues that are nice to have, but not essential. labels Oct 28, 2020
@gravestench gravestench moved this from Done to Low Priority in OpenDiablo 2 Game Engine Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Code Cleanup Doesn't materially affect the game Help Wanted Extra attention is needed Low Priority For issues that are nice to have, but not essential.
Projects
OpenDiablo 2 Game Engine
  
Low Priority
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gravestench