Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filenames and German Umlaut #3872

Open
jongough opened this issue Apr 30, 2024 · 3 comments
Open

Filenames and German Umlaut #3872

jongough opened this issue Apr 30, 2024 · 3 comments
Assignees
Labels

Comments

@jongough
Copy link
Contributor

Describe the bug
.gpx files containing german umlaut in filename / title cannot be saved or oadad under android.
Save routes with umlaut like ä, ö or ü in filename are empty
Files saved under windows containing umlaut cannot be loaded for example from draw plugin.

To Reproduce
Steps to reproduce the behavior:

create route
give name containing ä, ö or ü
export route with a filename containing ä, ö or ü
file is empty

or with draw plugin

create area on windows
give title containing ä, ö or ü
export are with od plugin
import are on android with od plugin

Expected behavior
Should work with national. characters, if not a warning dialog appears, that filename does not work.

Smartphone/Tablet (please complete the following information if applicable):

Device: Galaxy Tab A 2019

Additional context
Test German Umlaut ä.zip
Draw Example.zip

Apeared first with od plugin, so reported jongough/ocpn_draw_pi#530

See: #3363 (comment)

The issue was closed without explanation. The problem still exists in OCPN when run on Android. See #3363 (comment) where it is described in which part of OCPN the issue exists.

This needs fixing not closing without explanations

@jongough jongough added the bug label Apr 30, 2024
@bdbcat
Copy link
Member

bdbcat commented May 1, 2024

Two considerations:

  1. Umlaut in filename: This is a system issue, probably related to wxWidgets file selector dialog.
  2. Umlaut in GPX file contents, e.g. "Title, Name": This relates to XML parser library used by OCPN.

May I understand that this entire issue (both parts) relates to Android only?

@jongough
Copy link
Contributor Author

jongough commented May 1, 2024

I have tried the ODraw gpx file both with and without the umlaut in the filename. I did not change the content at all. With the umlaut the file does not load, without the umlaut (just renamed the file to remove it) it did load and displayed correctly.

I have tried importing the gpx files supplied above on a ubuntu system and it works fine, but on an Android phone it does not complain but nothing happens to the contents. I tried debugging it on the ubuntu system and could see where it went to do the file access and that is where I saw the android only bits of code that I think are not working. I don't have an android system I can run debugging on to see which bit actually fails, so cannot narrow it down any further.

So it would appear to just be the filename processing.

@bdbcat
Copy link
Member

bdbcat commented May 1, 2024

OK, thanks.
Will debug on Android, as time allows.

@bdbcat bdbcat self-assigned this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants