Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate Flatpak build setup #3856

Open
leamas opened this issue Apr 28, 2024 · 0 comments
Open

De-duplicate Flatpak build setup #3856

leamas opened this issue Apr 28, 2024 · 0 comments

Comments

@leamas
Copy link
Collaborator

leamas commented Apr 28, 2024

Is your feature request related to a problem? Please describe.
The official Flatpak packaging which creates packages users can download lives at flathub. We also maintain a Flatpak setup in the flatpak/ directory. This includes manifest, patches and the shared_modules git submodule.

As of today, the flatpak/ directory represents a duplicated effort which by definition means more work and poor quality.

Describe the solution you'd like
The main benefit of current setup is make -f ../flatpak/Makefile build which builds and installs a local Flatpak build. This interface is sound and should be kept as is.

Instead of using local more or less correct copies of manifest, patches and shared_modules we should use the flathub sources and build from those. This will include some minor patching to the manifest, symlinks and using the shared_modules git submodule.

The main thing is making the flathub setup a submodule in the flatpak/ directory.

Additional Context
We are now entering the beta cycle, and beta packages are created usng flathub. Thus, no hurry.

@leamas leamas added this to the OpenCPN 5.12.0 milestone Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant