Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subdirs #32

Open
drwetter opened this issue Dec 15, 2019 · 10 comments
Open

Subdirs #32

drwetter opened this issue Dec 15, 2019 · 10 comments

Comments

@drwetter
Copy link

.. are not working or am I missing something?

For our German Chapter we have links like https://www.owasp.org/index.php/OWASP_German_Chapter_Stammtisch_Initiative/Hamburg and https://www.owasp.org/index.php/Germany/Chapter_Meetings (cc @bkimminich).

Thx, Dirk

@drwetter
Copy link
Author

Hi @hblankenship ,

this is currently a showstopper for us. Please advise.

Thanks in advance, Dirk

@bkimminich
Copy link
Member

bkimminich commented Dec 19, 2019

I guess I stackoverflowed the problem...

remote_theme: "owasp/www--site-theme"
plugins:
 - jekyll-include-cache-0.2.0
include:
 - 'stammtische'
 - 'stammtische/hamburg'
 - 'chapter_meetings'

Now the subdirs work to some extent. Open issues:

  • tabs are broken once you are in a subdirectory, because they seem to be trying to resolve relatively within the subdir
  • the sidenav is not inherited from the repo, only from the very top level it seems. I guess this can be fixed somehow without duplicating the nav files

image

@drwetter
Copy link
Author

ok, thanks. One step forward.

@hblankenship
Copy link
Collaborator

Subdirs and tabs within them work without the config changes unless I recently broke something. They require an info.md file within the subdir (with col-sidebar).

@drwetter
Copy link
Author

Do you have an example of such an info.md?

@hblankenship
Copy link
Collaborator

@drwetter
Copy link
Author

Looks good, Thanks. I'll give it a try and let you know

drwetter added a commit to OWASP/www-chapter-germany that referenced this issue Dec 19, 2019
@drwetter
Copy link
Author

(Kind of ) works. Thanks.

See https://www2.owasp.org/www-chapter-germany/stammtische/

Not sure though what causes the header to appear/disappear. If e.g. I add tags the tabs show up again.

And what is the deal with the subdir info. What can I modify and what not?

@hblankenship
Copy link
Collaborator

See the https://www2.owasp.org/migration page for details on the various items, especially the section on tabs. Let me know if that doesn't answer your question.

@drwetter
Copy link
Author

Harold, that are the basics. But unless I overlooked something it doesn't tell me why the info.md need to contain what you suggested and when I modify things, what is going to happen. Also it doesn't mention when I readd tags again the tabs show up.

And honestly to find out this is quite tedious process with try and error.

It's enough for me today. I went through a lot of turn around cycles ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants