Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move or merge 8.3.5 to V7 #1960

Closed
elarlang opened this issue May 15, 2024 · 3 comments · Fixed by #1962
Closed

move or merge 8.3.5 to V7 #1960

elarlang opened this issue May 15, 2024 · 3 comments · Fixed by #1962
Assignees
Labels
1) Discussion ongoing Issue is opened and assigned but no clear proposal yet next meeting Filter for leaders V7 Temporary label for grouping logging related issues _5.0 - prep This needs to be addressed to prepare 5.0

Comments

@elarlang
Copy link
Collaborator

Current 8.3.5:

# Description L1 L2 L3 CWE
8.3.5 Verify accessing sensitive data is audited (without logging the sensitive data itself), if the data is collected under relevant data protection directives or where logging of access is required. 532

First there was proposal and agreement to move it to V7, as it talks about logging: #1444 (comment), #1444 (comment)

When prepared for PR, I stopped with the question: is it covered or can be merged to 7.2.2?

# Description L1 L2 L3 CWE
7.2.2 [MODIFIED] Verify that all access control decisions are logged including failed attempts. 285

ping @tghosth

@elarlang elarlang added the V7 Temporary label for grouping logging related issues label May 15, 2024
@elarlang elarlang added the next meeting Filter for leaders label May 15, 2024
@tghosth
Copy link
Collaborator

tghosth commented May 16, 2024

8.3.5 is talking about specifically logging access to sensitive data. E.g. in law enforcement or medical settings, an application would be expected to keep an audit trail of which user's access which people's personal files.

As such I disagree with merging but would suggest some modifications:

# Description L1 L2 L3 CWE
8.3.5 [MODIFIED] Verify that accessing sensitive data is audited (without logging the sensitive data itself), if the data is collected under relevant data protection directives or where logging of access is required by relevant data protection requirements. 532

@elarlang
Copy link
Collaborator Author

I think those can be merged, as functionality and information for (current) 8.3.5 is covered by 7.2.2 anyway.

If you think it is really important to have them separately, then let it be - coverage stays. The second part of the requirement forced me to read it 3 times ...

Maybe to the direction

Verify that accessing sensitive data is logged (without logging the sensitive data itself) if it is required by relevant data protection requirements.

@tghosth
Copy link
Collaborator

tghosth commented May 19, 2024

Opened #1962 with a proposal similar to the above

@tghosth tghosth added 1) Discussion ongoing Issue is opened and assigned but no clear proposal yet _5.0 - prep This needs to be addressed to prepare 5.0 labels May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1) Discussion ongoing Issue is opened and assigned but no clear proposal yet next meeting Filter for leaders V7 Temporary label for grouping logging related issues _5.0 - prep This needs to be addressed to prepare 5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants