Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most recent artifacts #1848

Open
tghosth opened this issue Jan 25, 2024 · 3 comments
Open

Most recent artifacts #1848

tghosth opened this issue Jan 25, 2024 · 3 comments
Assignees
Labels
1) Discussion ongoing Issue is opened and assigned but no clear proposal yet MAKEFILE _5.0 - Not blocker This issue does not block 5.0 so if it gets addressed then great, if not then fine.

Comments

@tghosth
Copy link
Collaborator

tghosth commented Jan 25, 2024

I like the fact that the new automation only builds the updated documents if something in that location has changed.

However, it then makes it trickier to find the latest artifacts. E.g. how do I find the most recent 4.0 artifacts?

Any thoughts?

One option is to change the build task to run once a day on all 3 builds but that seems a little blunt, is there an easier way to achieve this @ike ?

@tghosth tghosth added MAKEFILE _5.0 - Not blocker This issue does not block 5.0 so if it gets addressed then great, if not then fine. labels Jan 25, 2024
@ike
Copy link
Collaborator

ike commented Jan 27, 2024

Yeah, I've considered this a bit, and I'm torn: on the one hand, artifacts are an ephemeral, point-in-time build that doesn't produce any commits, on the other hand, they're hard to find and relate to the state of the repo.

Another option is to commit the built files to the pull request. The builds would appear in the pull request along with any source changes, as an automated commit. The action would still only build if the relevant source had changed. I'd be curious of your thoughts on this approach.

There are probably other considerations here, like cutting versioned dev releases after merges to master, etc. There's lots of flexibility, we just need to find an approach that works well with the team's workflow.

@tghosth
Copy link
Collaborator Author

tghosth commented Jan 29, 2024

let's leave it for now. I think we need to think about this more.

@ike
Copy link
Collaborator

ike commented Jan 29, 2024

Agreed, sounds good to me.

@ike ike added the 1) Discussion ongoing Issue is opened and assigned but no clear proposal yet label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1) Discussion ongoing Issue is opened and assigned but no clear proposal yet MAKEFILE _5.0 - Not blocker This issue does not block 5.0 so if it gets addressed then great, if not then fine.
Projects
None yet
Development

No branches or pull requests

2 participants