Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to use the same environment for GitHub Actions and local development #157

Closed
wigging opened this issue Apr 3, 2024 · 1 comment
Closed
Assignees

Comments

@wigging
Copy link
Collaborator

wigging commented Apr 3, 2024

The Format Check workflow in GitHub Actions passes but in my local environment I get the following errors:

would reformat /Desktop/ORNL/FlowceptZambeze/zambeze/zambeze/orchestration/plugins_message_template_engine.py
would reformat /Desktop/ORNL/FlowceptZambeze/zambeze/zambeze/orchestration/plugins_message_validator.py

Oh no! 💥 💔 💥
2 files would be reformatted, 111 files would be left unchanged.

The GitHub Action workflow is using black 24.3 but in my local environment I'm using 23.11. The different versions are causing different format results which is why black may pass locally but fail in the GitHub Actions workflow and vice versa. The same Python environment needs to be used on local machines and for Github Actions to avoid this problem.

@wigging wigging self-assigned this Apr 3, 2024
@wigging
Copy link
Collaborator Author

wigging commented May 31, 2024

The black formatter for this project has been replaced with ruff. Configuration for ruff can be done in the pyproject.toml file which ensures a similar linter/formatter environment for local and remote tests. Closing this issue as it's no longer relevant due to recent changes to the project.

@wigging wigging closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant