Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new config unit test #51

Open
streeve opened this issue Dec 1, 2021 · 6 comments
Open

Add new config unit test #51

streeve opened this issue Dec 1, 2021 · 6 comments
Assignees
@streeve @pzhanggit

Comments

@streeve
Copy link
Collaborator

streeve commented Dec 1, 2021

Compare CI JSON entries (run directly in CI) to example JSON
@streeve
Copy link
Collaborator Author

streeve commented Dec 1, 2021

Bug fixed in #44

@pzhanggit
Copy link
Collaborator

You made it! Thank you! @streeve

@allaffa
Copy link
Collaborator

allaffa commented Mar 29, 2022

@streeve @pzhanggit
can we close this issue?

@streeve
Copy link
Collaborator Author

streeve commented Mar 29, 2022

No, this is intended to make sure that the input files for untested examples (e.g. LSMS) at least contain everything needed.

@pzhanggit
Copy link
Collaborator

Current

HydraGNN/tests/test_config.py

Line 18 in 5931f04

def pytest_config(config_file):
is for this purpose?

@streeve
Copy link
Collaborator Author

streeve commented Mar 29, 2022 •
edited

Yes, but currently only checks a few variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@streeve streeve

@pzhanggit pzhanggit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@allaffa @streeve @pzhanggit