[Bug] 3.8 recovery

[sedghi]

Describe the Bug

Here are the bugs that need to be fixed in the 3.8.1 release

• tmtv cannot use the threshold tool
• Segmentation Panel Will not add a new segmentation if Layout is changed [Bug]  #4046
• [Bug] Volume rendering broken if using DICOM JSON data source #4081
• UI bug in Segmentation panel "Segmentation List" panel does not display all segmentations in list - 3.9.0-beta.6 [Bug]  #4132
• feat(typings): Enhance typing support with withAppTypes and custom services throughout OHIF #4090
• THe tmtv issue when sometimes the fusion has wrong inverted
• Switching between two SEGs causes hanging protocol button to become unresponsive (3.9.14)[Bug]  #4158

[sedghi]

Threshold tool tmtv does not work

[sedghi]

#4081

[sedghi]

Add the types

[sedghi]

#4132

[tzuccher]

INTERMITTENT **3.8.1 Bug Found while trying to reproduce #4046 - did not even get as far as the steps in 4046 *at this point i would fail 4046 in the current build i am testing with the following steps:
Segmentation Mode Select Add Segmentation = Black Viewports

Found in version (https://ohif-viewer-381-rc1.netlify.app/): 3.8.1, Commit hash: 1dcdc9d

Steps:

1. Select study CT/SEG HCC_004 and select the Segmentation button
2. From the viewer page, select the Add Segmentation verbiage in the right-side panel = black viewports that i cannot scroll or do anything with them
3. When i try and scroll within one of the black viewports there is an uncaught error in the console that accumulates as i scroll
   
   **this is repeatable for SEG studies as well as non-seg studies

[tzuccher]

INTERMITTENT **3.8.1 Bug Found while testing 4132:
Segmentation Mode drag in SEG series = black viewport where I cannot see the image or existing segmentations

Note: this issue is blocking me from testing #4132

Found in version (https://ohif-viewer-381-rc1.netlify.app/): 3.8.1, Commit hash: 1dcdc9d

Steps:

1. Select a SEG study and select the Segmentation button to go to the viewer screen - i used PCAMPMRI...
2. Scroll to the bottom of the study panel and dragged the last SEG item into viewport C - clicked yes = all 4 viewports went black
3. Clicking in viewport C = errors in console
   

[tzuccher]

Note that selecting a SEG study with the Basic Viewer mode (instead of the Segmentation mode), and then dragging in the SEG item into a viewport still produced a black viewport but, i was able to select a different layout option that seemed to produce images. After this, i was able to load in Segmentation mode without getting the black viewports - not sure what these steps did to help resolve the2 issues above that i reported...

[tzuccher]

Testing #4046 now that i can get the SEG to work again... (with 3.8.1 testing: 3.8.1, Commit hash:
1dcdc9d)
As described in the issue, using study WaterPhantom, there seems to be no issue or with study ACRIN ... with 934 instances.

#4046 appears to be ok if you can get around the black viewports reported above

#4132 - also looks better when you can get around the black viewports issue

#4158 - also looks good when you don't have the black viewports issue

Note that i was able to get the black viewport issue to happen again by repeating the steps above intermittently. It is still there in the background and i think needs to be resolved.

[tzuccher]

new issue?
Segmentation mode: within the viewport zoom in on the image = can no longer add segment shapes to any images

Found in version (https://ohif-viewer-381-rc1.netlify.app/): 3.8.1, Commit hash: 1dcdc9d

Steps:

1. Select a study and the Segmentation button
2. Click into a viewport, select Add Segment verbiage
3. Select brush and create shapes on image
4. Zoom in on the image
5. Select the brush tool again and attempt to create a shape on the same or different viewport = i can no longer create shapes