You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Eip712TypedDataEncoder throws when encoding typed data if the "EIP712Domain" is not listed in the TypedData types. But according to the most recent EIP712 spec this shouldn't be necessary, the js lib ethers even fails if this happens with this issue ethers-io/ethers.js#4000
Expected Behavior
The encode function should be able to encode the payload correctly without needing to specify the EIP712 type
Current Behavior
The encode function throws when the EIP712 type isn't defined in the typed payload
Possible Solution
Refactor the code to assume the EIP712 type from the spec
The
Eip712TypedDataEncoder
throws when encoding typed data if the"EIP712Domain"
is not listed in the TypedData types. But according to the most recent EIP712 spec this shouldn't be necessary, the js lib ethers even fails if this happens with this issue ethers-io/ethers.js#4000Expected Behavior
The encode function should be able to encode the payload correctly without needing to specify the EIP712 type
Current Behavior
The encode function throws when the EIP712 type isn't defined in the typed payload
Possible Solution
Refactor the code to assume the EIP712 type from the spec
Thank you @juanfranblanco
The text was updated successfully, but these errors were encountered: