Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JUnit4 to Junit5 #372

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

cypherean
Copy link

@cypherean cypherean commented Mar 20, 2023

Context

Upgrades JUnit4 to JUnit5.
Fixes #369

Doesn't upgrade mantis-control-plane-server due to issues with akka package

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

@sundargates
Copy link
Collaborator

Is this ready for review?

@cypherean
Copy link
Author

Not yet, there's a minor issue with one of the submodules that I'm trying to fix

@cypherean
Copy link
Author

cypherean commented Mar 24, 2023

Update @sundargates :
After upgrading to JUnit5 there's an issue with ResourceClusterActorTest. The actors are not being spawned so the resource cluster is throwing AskTimeoutException.

I've been trying to resolve this for quite some time. Can you help me with the same?

@cypherean
Copy link
Author

@sundargates following our conversation during office hours, I've left mantis-control-plane-server as it is on JUnit4 for now. I'll try to tackle that issue. Rest of the submodules have been upgraded to JUnit5, and PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade junit to junit5 in subprojects
2 participants