Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the limiter in "dry run" mode #195

Open
dkelmer opened this issue Feb 26, 2024 · 1 comment
Open

Enable the limiter in "dry run" mode #195

dkelmer opened this issue Feb 26, 2024 · 1 comment

Comments

@dkelmer
Copy link

dkelmer commented Feb 26, 2024

Is it possible to enable the interceptor in a dry-run mode? The goal would be to enable it and have metrics and logs to indicate when it would have limited traffic, but not actually reject any requests.

@umairk79
Copy link
Collaborator

Hi, this is not currently possible but you can extend existing code to achieve the dry run mode. You can either:

  1. Create your own limiter that returns a new Listener with your new metrics and logs here instead of returning a Optional.empty()
  2. Or, create your own interceptor that doesn't close the call if an empty listener token is received here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants