Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unavailable is misleading #162

Open
abersnaze opened this issue Aug 14, 2020 · 1 comment
Open

Unavailable is misleading #162

abersnaze opened this issue Aug 14, 2020 · 1 comment

Comments

@abersnaze
Copy link
Contributor

private static final Status LIMIT_EXCEEDED_STATUS = Status.UNAVAILABLE.withDescription("Client concurrency limit reached");

Could this be changed to RESOURCE_EXHAUSTED that doesn't make it look like the server is down?

@sukanth
Copy link

sukanth commented Sep 14, 2020

@abersnaze do you want to change the variable UNAVAILABLE to RESOURCE_EXHAUSTED? looks like this variable is not part of this codebase. It is coming as a dependency from the grpc-core library we may have to change that library in order to make this change. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants