Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning for periodic BCs in par #502

Open
dshaver-ANL opened this issue Jun 2, 2023 · 0 comments
Open

warning for periodic BCs in par #502

dshaver-ANL opened this issue Jun 2, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@dshaver-ANL
Copy link
Contributor

Describe the bug
The code does not throw an error when trying to set periodic BC in the .par file.
A user may have a mesh where they have non-zero periodic BoundaryIDs (as with the wirehexmesher) and incorrectly try to set them in the par file. We should warn them when they try.

To Reproduce
include the following in a par file for a mesh with BCids 1, 2, 3, and 4
[VELOCITY]
boundaryTypeMap = wall, wall, periodic, periodic

Expected behavior
Is there any scenario where periodic BCs can or should be set in the par file? If not, we should catch this as an invalid BC choice.

Desktop (please complete the following information):

  • OS: CentOS
  • Version 7
  • NekRS V23.0.3

Additional context
The code will echo this back

================ ELLIPTIC SETUP VELOCITY ================
bID 1 -> bcType zeroValue
bID 2 -> bcType zeroValue
bID 3 -> bcType periodic
bID 4 -> bcType periodic

which would imply this is the correct way to set the BC.

@stgeke stgeke added the bug Something isn't working label Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants