Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdparam references nelgv before it is read #697

Open
fischer1 opened this issue Dec 18, 2020 · 2 comments
Open

rdparam references nelgv before it is read #697

fischer1 opened this issue Dec 18, 2020 · 2 comments
Labels

Comments

@fischer1
Copy link
Contributor

These are just diagnostics, so don't really impact code function... but are bugs in any case:

  if (ifneknekc.and.(nelgv.ne.nelgt)) call exitti(
 $ 'ABORT: nek-nek not supported w/ conj. ht transfer$',1)

  if (ifchar.and.(nelgv.ne.nelgt)) call exitti(
 $ 'ABORT: IFCHAR curr. not supported w/ conj. ht transfer$',nelgv)
@fischer1 fischer1 added the bug label Dec 18, 2020
@fischer1
Copy link
Contributor Author

tdsum is also used in dssum before time00 is called.

We probably should call time00 once with (say) init

It looks like nek_init is not intializing the lagged variables in bm1lag, bm1, etc.

Here's another:
The variable (ifrzer(1)) has an undefined value.

@stgeke
Copy link
Contributor

stgeke commented Dec 19, 2020

This applies only for rea:
https://github.com/Nek5000/Nek5000/blob/master/core/connect2.f#L46

In case of .par nelgt is defined before checking params:
https://github.com/Nek5000/Nek5000/blob/master/core/reader_par.f#L23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants